Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump alibi-detect to 0.8.1 in adserver #3871

Merged
merged 4 commits into from
Feb 2, 2022
Merged

bump alibi-detect to 0.8.1 in adserver #3871

merged 4 commits into from
Feb 2, 2022

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

We need to have up to date alibi-detect

Which issue(s) this PR fixes:

Fixes #3864

Special notes for your reviewer:

@RafalSkolasinski RafalSkolasinski marked this pull request as draft January 20, 2022 12:16
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review January 28, 2022 09:50
@RafalSkolasinski RafalSkolasinski marked this pull request as draft January 28, 2022 09:51
@RafalSkolasinski
Copy link
Contributor Author

integration / notebook tests passed
image
but now I see failure in unit tests that was not present before

@RafalSkolasinski
Copy link
Contributor Author

It had to be some flakiness in a single run during installation of dependencies, all good again
image

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review January 28, 2022 09:56
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we need to regenerate artifacts?

@@ -8,7 +8,7 @@ license = "Apache-2.0"
[tool.poetry.dependencies]
python = "^3.7"
seldon-core = { path = "_seldon_core", develop = false }
alibi-detect = "0.6.2"
alibi-detect = "0.8.1"
numpy = "1.19.5"
cloudevents = "1.2.0"
tensorflow = "2.4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly out of date, and alibi-detect is compatible with tf version up to 2.7, worth upgrading?

Can be left as a separate PR though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense. I can try and see where it lead me - if no issues could go in here

components/alibi-detect-server/Dockerfile Show resolved Hide resolved
@axsaucedo
Copy link
Contributor

Nice one - looks good
/approve

@axsaucedo axsaucedo merged commit fd79a63 into SeldonIO:master Feb 2, 2022
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, sakoush

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade alibi-detect to 0.8.1
4 participants