-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump alibi-detect to 0.8.1 in adserver #3871
Conversation
/test integration |
/test notebooks |
/test notebooks |
/test integration |
/test integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do we need to regenerate artifacts?
@@ -8,7 +8,7 @@ license = "Apache-2.0" | |||
[tool.poetry.dependencies] | |||
python = "^3.7" | |||
seldon-core = { path = "_seldon_core", develop = false } | |||
alibi-detect = "0.6.2" | |||
alibi-detect = "0.8.1" | |||
numpy = "1.19.5" | |||
cloudevents = "1.2.0" | |||
tensorflow = "2.4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly out of date, and alibi-detect
is compatible with tf version up to 2.7, worth upgrading?
Can be left as a separate PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this makes sense. I can try and see where it lead me - if no issues could go in here
Nice one - looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo, sakoush The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We need to have up to date alibi-detect
Which issue(s) this PR fixes:
Fixes #3864
Special notes for your reviewer: