Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cert-manager API version #3888

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Conversation

jonathansp
Copy link
Contributor

@jonathansp jonathansp commented Jan 24, 2022

What this PR does / why we need it:

Updates deprecated cert-manager API versions.

Which issue(s) this PR fixes:

Fixes #3887

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Hi @jonathansp. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonathansp
Copy link
Contributor Author

/assign @RafalSkolasinski

@jonathansp
Copy link
Contributor Author

cc @cliveseldon

@ukclivecox
Copy link
Contributor

/test notebooks

1 similar comment
@ukclivecox
Copy link
Contributor

/test notebooks

@jonathansp
Copy link
Contributor Author

@cliveseldon @RafalSkolasinski CI step Docs Test / docs-build (pull_request) has failed, but it seems to be unrelated to the PR changes.

@ukclivecox
Copy link
Contributor

Thanks. Looks good. @jonathansp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy cert-manager API versions are no-longer served: v1alpha2, v1alpha3, and v1beta1
4 participants