Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3804 Removal of Depricated Java Engine Resources #3845

Merged
merged 16 commits into from
Jan 24, 2022

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Jan 11, 2022

What this PR does / why we need it:
The Deprication of Java Engine Service Orchestrator started in 1.0 and fully finalised in 1.1. Since then the Java engine has been present but with deprication warning as no further maintenance upgrades taking place. The Java engine is now being removed toegether with all relevant references as it no longer receives feature, maintenance nor security updates.

Which issue(s) this PR fixes:

Fixes #3804

Included in this PR

  • Remove engine Java codebase
  • Remove CI references that build the image
  • Remove code paths that created depricated Java engine
  • Removing documentation references that use the engine
  • Add notes on UPGRADING.md about removal

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor Author

Notebook tests only one test failed - namely test_server_examples, I will run locally and will rerun integration tests
/test integration

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

Running the CI locally passes with only errors in known failing tests outlined in #3856 and #3857. Will rerun but we should be good for review.
/test integration

@axsaucedo axsaucedo changed the title WIP: 3804 Removal of Depricated Java Engine Resources 3804 Removal of Depricated Java Engine Resources Jan 18, 2022
@axsaucedo axsaucedo requested a review from ukclivecox January 18, 2022 09:57
@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

@axsaucedo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 777b9c0 link /test notebooks
integration 7723364 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit 6fc7f9b into SeldonIO:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code and resources from depricated Java-based service orchestrator
3 participants