Skip to content

Commit

Permalink
Updated all documentation samples to avoid anotation
Browse files Browse the repository at this point in the history
  • Loading branch information
axsaucedo committed Jan 10, 2022
1 parent 9ce9d10 commit 777b9c0
Show file tree
Hide file tree
Showing 18 changed files with 2 additions and 59 deletions.
2 changes: 0 additions & 2 deletions examples/dvc/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ kind: SeldonDeployment
metadata:
name: minio-dvc-sklearn
spec:
annotations:
seldon.io/executor: "true"
name: iris
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions examples/dvc/sklearn_dvc_minio.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,6 @@
"metadata:\n",
" name: minio-dvc-sklearn\n",
"spec:\n",
" annotations:\n",
" seldon.io/executor: \"true\"\n",
" name: iris\n",
" predictors:\n",
" - componentSpecs:\n",
Expand Down
2 changes: 0 additions & 2 deletions examples/minio/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ kind: SeldonDeployment
metadata:
name: minio-sklearn
spec:
annotations:
seldon.io/executor: "true"
name: iris
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions examples/minio/minio.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,6 @@
"metadata:\n",
" name: minio-sklearn\n",
"spec:\n",
" annotations:\n",
" seldon.io/executor: \"true\"\n",
" name: iris\n",
" predictors:\n",
" - componentSpecs:\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ kind: SeldonDeployment
metadata:
name: rsi-predictor
spec:
annotations:
seldon.io/executor: "true"
name: rsi-predictor
predictors:
- componentSpecs:
Expand Down Expand Up @@ -37,4 +35,4 @@ spec:
name: rsi-predictor
type: MODEL
name: default
replicas: 1
replicas: 1
19 changes: 1 addition & 18 deletions executor/README.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,17 @@
# Seldon Executor

This Go project replaces the Seldon Java Engine. It is presently in development.
# Seldon Service Orchestrator

## Functionality

The focus is to provide a smaller more efficient graph orchestror.

* REST and gRPC for Seldon and Tensorflow protocols. Easily extendable to other protocols.
* Logging of request and or response payloads to arbitrary URLs with CloudEvents
* Tracing for REST and gRPC
* Prometheus metrics for REST and gRPC

Changes to existing service orchestrator

* All components must be REST or gRPC in agraph. No mixing.
* Not meta data additions to payloads are carried out by the executor.


## Testing

You can choose to use this executor by adding the annotation `seldon.io/executor: "true"`. This annotation will be active until this project progresses from incubating status.

An example is shown below:

```JSON
Expand All @@ -31,8 +22,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand All @@ -52,10 +41,4 @@ spec:
replicas: 1

```

## Development

We assume:

* Go 1.13

2 changes: 0 additions & 2 deletions executor/samples/local/graph/model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/kafka/logger/model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/logger/model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/metadata/broken_chain.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: deployment
predictors:
- graph:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/metadata/chain.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: deployment
predictors:
- graph:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/metadata/combiner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-mock-model
spec:
annotations:
seldon.io/executor: "true"
name: mock-deployment
predictors:
- graph:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/metadata/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-mock-model
spec:
annotations:
seldon.io/executor: "true"
name: mock-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/metrics/model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
8 changes: 0 additions & 8 deletions executor/samples/local/tfserving/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down Expand Up @@ -321,8 +319,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down Expand Up @@ -387,8 +383,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down Expand Up @@ -665,8 +659,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/tfserving/model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/tfserving/model_chain.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down
2 changes: 0 additions & 2 deletions executor/samples/local/tracing/model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
app: seldon
name: seldon-model
spec:
annotations:
seldon.io/executor: "true"
name: test-deployment
predictors:
- componentSpecs:
Expand Down

0 comments on commit 777b9c0

Please sign in to comment.