Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pdb to namespaced roles #3694

Merged
merged 1 commit into from
Oct 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,38 @@ rules:
- get
- patch
- update
- apiGroups:
- keda.sh
resources:
- scaledobjects
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- keda.sh
resources:
- scaledobjects/finalizers
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- keda.sh
resources:
- scaledobjects/status
verbs:
- get
- patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need patch for status?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same question for the others)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I guess it's probably the same as what curently in place for the other configuration right? If that is the case then we can merge having both aligned and then remove unnecessary permissions when/if relevant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah makes sense

- update
- apiGroups:
- machinelearning.seldon.io
resources:
Expand Down Expand Up @@ -127,6 +159,26 @@ rules:
- get
- patch
- update
- apiGroups:
- policy
resources:
- poddisruptionbudgets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- policy
resources:
- poddisruptionbudgets/status
verbs:
- get
- patch
- update
- apiGroups:
- v1
resources:
Expand Down
52 changes: 52 additions & 0 deletions operator/config/namespaced/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,38 @@ rules:
- get
- patch
- update
- apiGroups:
- keda.sh
resources:
- scaledobjects
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- keda.sh
resources:
- scaledobjects/finalizers
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- keda.sh
resources:
- scaledobjects/status
verbs:
- get
- patch
- update
- apiGroups:
- machinelearning.seldon.io
resources:
Expand Down Expand Up @@ -126,6 +158,26 @@ rules:
- get
- patch
- update
- apiGroups:
- policy
resources:
- poddisruptionbudgets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- policy
resources:
- poddisruptionbudgets/status
verbs:
- get
- patch
- update
- apiGroups:
- v1
resources:
Expand Down