Add pdb to namespaced roles #3694
Conversation
|
/test notebooks |
|
/test integration |
| - scaledobjects/status | ||
| verbs: | ||
| - get | ||
| - patch |
There was a problem hiding this comment.
Does it need patch for status?
There was a problem hiding this comment.
(Same question for the others)
There was a problem hiding this comment.
Actually, I guess it's probably the same as what curently in place for the other configuration right? If that is the case then we can merge having both aligned and then remove unnecessary permissions when/if relevant
There was a problem hiding this comment.
yeah makes sense
|
/test integration |
|
Seems all v2 server failures (xgboost, mlflow, sklearn) |
|
/test notebooks |
|
It seems integration tests failing were different (test label updates) so confirms flakiness |
|
It seems the explainer examples are failing consistently, but can't really seem how this PR is causing this. Wonder if this is actually happenign in master - will test the notebooks to validate |
|
@cliveseldon: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
|
explainer tests pass so seems mainly flakiness - merging |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3692
Special notes for your reviewer:
Does this PR introduce a user-facing change?: