Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibi explain 110 fix #3501

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Alibi explain 110 fix #3501

merged 2 commits into from
Aug 25, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Closes #3498 by bringing back non-standard seldon extension and documenting that it is also supported for the explainer API.

Which issue(s) this PR fixes:

Fixes #3498

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@RafalSkolasinski
Copy link
Contributor Author

@axsaucedo shall we merge this?

@axsaucedo
Copy link
Contributor

Nice one - integration and notebooks tests passing
/approve

@axsaucedo axsaucedo merged commit 1f4cecf into SeldonIO:master Aug 25, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update explainer URL to allow for empty parameter for tensorlfow protocol
3 participants