Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation in UPGRADING page that outlines new explainer URI model param limitation #3499

Closed
axsaucedo opened this issue Aug 19, 2021 · 4 comments
Assignees

Comments

@axsaucedo
Copy link
Contributor

Since version 1.10, we added changes in the explainer code which ensure that the model name in the v1 tfserving protocol is actually used, as opposed to before where it wasn't, so we should add documentation in case anyone was not using it.

@RafalSkolasinski
Copy link
Contributor

Summarizing the discussion we had on Slack.

The model-name is currently optional in the prediction API of Tensorflow protocol (in Seldon) as docoumented here:

a non-standard Seldon extension is available to call predict on the graph as a whole: /v1/models/:predict.

#3501 brings back this non-standard extension for the explainer API

@axsaucedo
Copy link
Contributor Author

@RafalSkolasinski are we OK to close this one?

@RafalSkolasinski
Copy link
Contributor

I believe so

@axsaucedo
Copy link
Contributor Author

OK cool, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants