Run black (nbQA) on notebooks as part of fmt/lint

[MarcoGorelli]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2885

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[seldondev]

Hi @MarcoGorelli. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[seldondev]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ivan-valkov
You can assign the PR to them by writing /assign @ivan-valkov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ukclivecox]

/ok-to-test

[ukclivecox]

/test notebooks

[axsaucedo]

It seems the tests get stuck on the customMetrics.ipynb notebook - it ran twice and it seems to terminate there twice. I can't really seem to find a reason why it would get stuck, but could you maybe revert the changes in this notebook so we can re-run

[MarcoGorelli]

have reverted - does that notebook pass on master?

[axsaucedo]

Ok perfecto - thank you @MarcoGorelli, let me re-run
/test notebooks

[axsaucedo]

/test notebooks

[axsaucedo]

@MarcoGorelli we actually found an issue in our integration tests, which should now be fixed with #3252. Once we merge that we should be able to rebase this branch and re-run the tests.

[MarcoGorelli]

Glad this could help uncover an issue - and sure, no hurry, if you ping me once that's in I'll rebase

[axsaucedo]

Thank you @MarcoGorelli - notebook tests have been fixed, can you rebase? We'll be able to re-run the tests

[axsaucedo]

/test notebooks

[axsaucedo]

Nice one @MarcoGorelli - all notebook tests pass, we should be good to merge

[MarcoGorelli]

Happy to help, and do let me know if you run into any issues with nbQA!