revert changes to examples/models/custom_metrics/customMetrics.ipynb

SeldonIO · May 30, 2021 · 87ebff0 · 87ebff0
1 parent 1cfcaec
commit 87ebff0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/examples/models/custom_metrics/customMetrics.ipynb b/examples/models/custom_metrics/customMetrics.ipynb
@@ -196,9 +196,9 @@
     }
    ],
    "source": [
-    "response = json.loads(responseRaw[0])\n",
+    "response=json.loads(responseRaw[0])\n",
     "print(response)\n",
-    "assert len(response[\"meta\"][\"metrics\"]) == 3"
+    "assert(len(response[\"meta\"][\"metrics\"]) == 3)"
    ]
   },
   {
@@ -282,9 +282,9 @@
     }
    ],
    "source": [
-    "response = json.loads(responseRaw[0])\n",
+    "response=json.loads(responseRaw[0])\n",
     "print(response)\n",
-    "assert response[\"data\"][\"result\"][0][\"metric\"][\"__name__\"] == \"mycounter_total\""
+    "assert(response['data'][\"result\"][0][\"metric\"][\"__name__\"]=='mycounter_total')"
    ]
   },
   {
@@ -313,9 +313,9 @@
     }
    ],
    "source": [
-    "response = json.loads(\"\".join(responseRaw))\n",
+    "response=json.loads(\"\".join(responseRaw))\n",
     "print(response)\n",
-    "assert len(response[\"meta\"][\"metrics\"]) == 3"
+    "assert(len(response[\"meta\"][\"metrics\"]) == 3)"
    ]
   },
   {
@@ -359,13 +359,10 @@
     }
    ],
    "source": [
-    "response = json.loads(responseRaw[0])\n",
+    "response=json.loads(responseRaw[0])\n",
     "print(response)\n",
-    "assert response[\"data\"][\"result\"][0][\"metric\"][\"__name__\"] == \"mycounter_total\"\n",
-    "assert (\n",
-    "    response[\"data\"][\"result\"][0][\"metric\"][\"image_name\"]\n",
-    "    == \"seldonio/model-with-metrics\"\n",
-    ")"
+    "assert(response['data'][\"result\"][0][\"metric\"][\"__name__\"]=='mycounter_total')\n",
+    "assert(response['data'][\"result\"][0][\"metric\"][\"image_name\"]=='seldonio/model-with-metrics')"
    ]
   },
   {

diff --git a/python/Makefile b/python/Makefile
@@ -106,10 +106,10 @@ fmt:
 		--skip proto --skip seldon_core/proto --skip .eggs --skip .tox
 	nbqa black \
 		../ --nbqa-skip-bad-cells --nbqa-mutate \
-		--nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
+		--nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb|examples/models/custom_metrics/customMetrics\.ipynb)"
 	nbqa isort \
 		../ --profile black --nbqa-skip-bad-cells --nbqa-mutate \
-		--nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
+		--nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb|examples/models/custom_metrics/customMetrics\.ipynb)"
 
 lint: licenses
 	black \