Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow leader election to use configurable seldon-manager service account #3200

Merged
merged 1 commit into from
May 17, 2021
Merged

Allow leader election to use configurable seldon-manager service account #3200

merged 1 commit into from
May 17, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Adds missing Helm value usage for leader election template for seldon core operator helm chart

Which issue(s) this PR fixes:

Fixes #3168

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/test integration

@ukclivecox ukclivecox merged commit 69942e4 into SeldonIO:master May 17, 2021
@axsaucedo
Copy link
Contributor

Integration tests pass
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA name hardcoded in seldon-leader-election-role rbac
3 participants