Merge pull request #3200 from cliveseldon/3168_sa_hardwired

Allow leader election to use configurable seldon-manager service account
SeldonIO · May 17, 2021 · 69942e4 · 69942e4
2 parents 9fc261d + 4da80b2
commit 69942e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...charts/seldon-core-operator/templates/rolebinding_seldon-leader-election-rolebinding.yaml b/...charts/seldon-core-operator/templates/rolebinding_seldon-leader-election-rolebinding.yaml
@@ -15,6 +15,6 @@ roleRef:
   name: seldon-leader-election-role
 subjects:
 - kind: ServiceAccount
-  name: seldon-manager
+  name: '{{ .Values.serviceAccount.name }}'
   namespace: '{{ include "seldon.namespace" . }}'
 {{- end }}
diff --git a/operator/helm/split_resources.py b/operator/helm/split_resources.py
@@ -249,6 +249,7 @@ def helm_namespace_override():
                 if (
                     name == "seldon1-manager-rolebinding"
                     or name == "seldon1-manager-sas-rolebinding"
+                    or name == "seldon-leader-election-rolebinding"
                 ):
                     res["subjects"][0]["name"] = helm_value("serviceAccount.name")
                     res["subjects"][0]["namespace"] = helm_namespace_override()