Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements to metrics server example #2989

Merged
merged 2 commits into from
Mar 2, 2021
Merged

small improvements to metrics server example #2989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f224b5e
small improvements to metrics server example
ryandawsonuk Feb 25, 2021
b2571ca
small updates to README
ryandawsonuk Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions examples/feedback/feedback-metrics-server/README.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
"See the centralized logging example (also in the examples directory) for how to set these up.\n",
"\n",
"Easiest way is to run `examples/centralized-logging/full-kind-setup.sh` and then:\n",
" `helm delete seldon-core-loadtesting`\n",
" `seldon-single-model`\n",
"```bash\n",
" helm delete seldon-core-loadtesting\n",
" helm delete seldon-single-model\n",
"```\n",
"\n",
"Then port-forward to that ingress on localhost:8080 in a separate terminal either of (istio suggested):\n",
"\n",
Expand Down
4 changes: 2 additions & 2 deletions examples/feedback/feedback-metrics-server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ See the centralized logging example (also in the examples directory) for how to

Easiest way is to run `examples/centralized-logging/full-kind-setup.sh` and then:
`helm delete seldon-core-loadtesting`
`seldon-single-model`
`helm delete seldon-single-model`

Then port-forward to that ingress on localhost:8080 in a separate terminal with either of (istio suggested):

Expand Down Expand Up @@ -473,7 +473,7 @@ If you want to create a kservice, and you've installed knative eventing and knat

The value of the file `config/multiclass-service.yaml` would be:
```
apiVersion: serving.knative.dev/v1alpha1
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: seldon-multiclass-model-metrics
Expand Down
Loading