small improvements to metrics server example #2989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed https://github.com/SeldonIO/seldon-core/tree/master/examples/feedback/metrics-server was using an old version of knative so I thought I would update it... then I realised it doesn't really use knative at all as the logger uri points directly at the metrics server.
So instead I removed knative from this particular example. If people want to see the knative flow they can use the simlar example https://github.com/SeldonIO/seldon-core/tree/master/examples/feedback/feedback-metrics-server (and have added a note saying this). This makes it a bit easier both to run and to maintain.
Have run the notebook through and all works (which makes sense as haven't really made a substantial change here).