Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocols_example #2564

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Fix protocols_example #2564

merged 2 commits into from
Oct 22, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Oct 21, 2020

What this PR does / why we need it:

Fixes two notebooks that were recently failing in CI:

  • custom_metrics -> flakiness, increased sleep time as temporary measure
  • protocols_example -> missing Protocol: TCP

Which issue(s) this PR fixes:

Fixes #2569

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Oct 21 13:13:16 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2564/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2564 --build=1

@seldondev
Copy link
Collaborator

Wed Oct 21 13:13:21 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2564/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2564 --build=3

@seldondev
Copy link
Collaborator

Wed Oct 21 13:13:26 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2564/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2564 --build=2

@RafalSkolasinski RafalSkolasinski changed the title Fix/failing/notebooks Fix protocols_example and custom_metrics notebooks Oct 21, 2020
@RafalSkolasinski
Copy link
Contributor Author

hmmm... seems custom_metrics one is still flaky...

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Wed Oct 21 16:04:43 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2564/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2564 --build=4

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 03928db link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

Well... I am afraid that this PR is fixing only the protocols_example in the end...

@RafalSkolasinski RafalSkolasinski changed the title Fix protocols_example and custom_metrics notebooks Fix protocols_example Oct 22, 2020
@RafalSkolasinski
Copy link
Contributor Author

The notebook that was meant to be fixed got fixed, we should merge it

@axsaucedo axsaucedo merged commit 166c0ea into SeldonIO:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocols_example notebook is failing tests
3 participants