-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix protocols_example #2564
Fix protocols_example #2564
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/test notebooks |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Oct 21 13:13:16 UTC 2020 impatient try |
Wed Oct 21 13:13:21 UTC 2020 impatient try |
Wed Oct 21 13:13:26 UTC 2020 impatient try |
hmmm... seems custom_metrics one is still flaky... |
/test notebooks |
Wed Oct 21 16:04:43 UTC 2020 impatient try |
@RafalSkolasinski: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Well... I am afraid that this PR is fixing only the protocols_example in the end... |
The notebook that was meant to be fixed got fixed, we should merge it |
What this PR does / why we need it:
Fixes two notebooks that were recently failing in CI:
custom_metrics -> flakiness, increased sleep time as temporary measureProtocol: TCP
Which issue(s) this PR fixes:
Fixes #2569
Special notes for your reviewer:
Does this PR introduce a user-facing change?: