Merge pull request #2564 from RafalSkolasinski/fix/failing/notebooks

Fix protocols_example
SeldonIO · Oct 22, 2020 · 166c0ea · 166c0ea
2 parents 7abd510 + 03928db
commit 166c0ea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/examples/models/custom_metrics/customMetrics.ipynb b/examples/models/custom_metrics/customMetrics.ipynb
@@ -78,9 +78,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "metadata": {
-    "scrolled": false
-   },
+   "metadata": {},
    "outputs": [],
    "source": [
     "!pygmentize model_rest.yaml"
@@ -132,7 +130,7 @@
    "outputs": [],
    "source": [
     "print(\"Waiting so metrics can be scraped\")\n",
-    "time.sleep(3)"
+    "time.sleep(10)"
    ]
   },
   {
@@ -195,9 +193,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "metadata": {
-    "scrolled": false
-   },
+   "metadata": {},
    "outputs": [],
    "source": [
     "!pygmentize model_grpc.yaml"
@@ -252,7 +248,7 @@
    "outputs": [],
    "source": [
     "print(\"Waiting so metrics can be scraped\")\n",
-    "time.sleep(3)"
+    "time.sleep(10)"
    ]
   },
   {
@@ -293,13 +289,6 @@
    "source": [
     "!helm delete seldon-core-analytics --namespace seldon-system"
    ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": []
   }
  ],
  "metadata": {
@@ -318,9 +307,9 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.8"
+   "version": "3.7.8"
   }
  },
  "nbformat": 4,
- "nbformat_minor": 2
+ "nbformat_minor": 4
 }
diff --git a/notebooks/protocol_examples.ipynb b/notebooks/protocol_examples.ipynb
@@ -305,6 +305,7 @@
     "          ports:\n",
     "          - containerPort: 8501\n",
     "            name: http\n",
+    "            protocol: TCP\n",
     "    graph:\n",
     "      name: halfplustwo\n",
     "      type: MODEL\n",
@@ -416,6 +417,7 @@
     "          ports:\n",
     "          - containerPort: 8500\n",
     "            name: grpc\n",
+    "            protocol: TCP\n",
     "    graph:\n",
     "      name: halfplustwo\n",
     "      type: MODEL\n",