Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executor's dependency on k8s.io/client-go #2106

Merged
merged 3 commits into from
Jul 13, 2020
+0 −77
Merged

Remove executor's dependency on k8s.io/client-go #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e38216d
REMOVAL: k8s.io/client-go
RafalSkolasinski Jul 7, 2020
a4a59c0
Remove completely SeldonDeploymentClient since it's not used anymore
Jul 10, 2020
3a93b7b
Update go.mod
Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 0 additions & 68 deletions executor/api/client/seldondeployment_client.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion executor/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ require (
gotest.tools v2.2.0+incompatible
k8s.io/api v0.17.2
k8s.io/apimachinery v0.17.2
k8s.io/client-go v0.17.2
sigs.k8s.io/controller-runtime v0.5.0
)

Expand Down
8 changes: 0 additions & 8 deletions executor/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,6 @@ func main() {
if err != nil {
logger.Error(err, "Failed to get predictor from Env")
panic(err)
} else if predictor == nil {
logger.Info("Trying to get predictor from API")
seldonDeploymentClient := seldonclient.NewSeldonDeploymentClient(configPath)
predictor, err = seldonDeploymentClient.GetPredictor(*sdepName, *namespace, *predictorName)
if err != nil {
logger.Error(err, "Failed to find predictor", "name", predictor)
panic(err)
}
}
}

Expand Down