Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executor's dependency on k8s.io/client-go #2106

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jul 10, 2020

What this PR does / why we need it:

Remove k8s.io/client-go as a direct dependency of the executor by getting rid of the SeldonDeploymentClient. This means that, from now on, the executor will only be able to read SeldonDeployment resources passed explicitly from the environment or as files.

Note that k8s.io/client-go may still be present in the go.sum as a 2nd-level dependency through the operator.

Which issue(s) this PR fixes:

Fixes #2092

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@adriangonz
Copy link
Contributor Author

/cc @RafalSkolasinski @axsaucedo @cliveseldon

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jul 10 15:29:16 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2106/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2106 --build=2

@seldondev
Copy link
Collaborator

Fri Jul 10 15:29:36 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2106/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2106 --build=1

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Jul 10 15:34:08 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2106/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2106 --build=3

@RafalSkolasinski
Copy link
Contributor

Looks good to me! Nice one.

@agm do we have results of notebooks / integration tests for this one?
Good to merge if confirmed that they're passing (don't see reason they shouldn't).

@axsaucedo
Copy link
Contributor

/test integration
/test notebook

@seldondev
Copy link
Collaborator

Mon Jul 13 12:07:25 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2106/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2106 --build=4

@axsaucedo
Copy link
Contributor

/test notebooks

@seldondev
Copy link
Collaborator

Mon Jul 13 12:22:00 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2106/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2106 --build=5

@RafalSkolasinski
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Mon Jul 13 15:02:46 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2106/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2106 --build=6

@RafalSkolasinski
Copy link
Contributor

Notebook tests have passed, now waiting for integration tests (there was one failure, hence restart).

@RafalSkolasinski
Copy link
Contributor

Tests passed!
🚀

@RafalSkolasinski
Copy link
Contributor

Merging manually

@RafalSkolasinski RafalSkolasinski merged commit b8a9291 into SeldonIO:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Executor's dependency on client-go
4 participants