-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove executor's dependency on k8s.io/client-go #2106
Remove executor's dependency on k8s.io/client-go #2106
Conversation
/cc @RafalSkolasinski @axsaucedo @cliveseldon |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Jul 10 15:29:16 UTC 2020 impatient try |
Fri Jul 10 15:29:36 UTC 2020 impatient try |
/test integration |
Fri Jul 10 15:34:08 UTC 2020 impatient try |
Looks good to me! Nice one. @agm do we have results of notebooks / integration tests for this one? |
/test integration |
Mon Jul 13 12:07:25 UTC 2020 impatient try |
/test notebooks |
Mon Jul 13 12:22:00 UTC 2020 impatient try |
/test integration |
Mon Jul 13 15:02:46 UTC 2020 impatient try |
Notebook tests have passed, now waiting for integration tests (there was one failure, hence restart). |
Tests passed! |
Merging manually |
What this PR does / why we need it:
Remove
k8s.io/client-go
as a direct dependency of theexecutor
by getting rid of theSeldonDeploymentClient
. This means that, from now on, theexecutor
will only be able to readSeldonDeployment
resources passed explicitly from the environment or as files.Note that
k8s.io/client-go
may still be present in thego.sum
as a 2nd-level dependency through theoperator
.Which issue(s) this PR fixes:
Fixes #2092
Special notes for your reviewer:
Does this PR introduce a user-facing change?: