Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use production server by default #2047

Merged
merged 9 commits into from
Jul 7, 2020

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jun 29, 2020

Fixes #1993

Changelog

  • Run Gunicorn by default with 1 worker and 10 threads
  • Add --threads / GUNICORN_THREADS flags to control number of threads
  • Add --debug / SELDON_DEBUG flags to enable Flask's development server
  • Apply the same above to the metrics server
  • Update docs
Changed Python wrapper so that it runs Gunicorn with a single worker by default.
Added `GUNICORN_THREADS` environment variable to control the fixed number of threads on each Gunicorn worker. 

@adriangonz
Copy link
Contributor Author

/cc @RafalSkolasinski @axsaucedo

@seldondev
Copy link
Collaborator

Mon Jun 29 15:24:27 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=1

@seldondev
Copy link
Collaborator

Mon Jun 29 15:24:38 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=2

@adriangonz
Copy link
Contributor Author

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Thu Jul 2 08:52:56 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=4

@seldondev
Copy link
Collaborator

Thu Jul 2 08:53:24 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=3

@axsaucedo
Copy link
Contributor

Seems ambassador install failed, strange...
/test integration

@seldondev
Copy link
Collaborator

Thu Jul 2 13:11:18 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=5

@seldondev
Copy link
Collaborator

@adriangonz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 984345a link /test notebooks
integration 984345a link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Jul 6 09:26:47 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=6

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Jul 6 14:58:48 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=7

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Mon Jul 6 15:07:34 UTC 2020
The logs for [notebooks] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=8

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jul 7 12:18:40 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=9

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jul 7 12:31:21 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2047/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2047 --build=10

@axsaucedo
Copy link
Contributor

Integration tests have passed

/approve

@axsaucedo axsaucedo merged commit a061624 into SeldonIO:master Jul 7, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable production mode in Python server by default
3 participants