Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable production mode in Python server by default #1993

Closed
adriangonz opened this issue Jun 22, 2020 · 3 comments · Fixed by #2047
Closed

Enable production mode in Python server by default #1993

adriangonz opened this issue Jun 22, 2020 · 3 comments · Fixed by #2047
Assignees
Labels
priority/p0 triage Needs to be triaged and prioritised accordingly
Milestone

Comments

@adriangonz
Copy link
Contributor

adriangonz commented Jun 22, 2020

Currently, the Python server only uses Gunicorn and production settings if there are multiple workers. We should make sure that by default, even if it runs with a single worker, it also runs with production settings.

Additionally, it could be interesting to explore if it's possible (and makes sense) to always run the Python server with Gunicorn (i.e. even with a single worker).

@adriangonz adriangonz added the triage Needs to be triaged and prioritised accordingly label Jun 22, 2020
@adriangonz
Copy link
Contributor Author

/priority p0

@chengcheng-pei
Copy link
Contributor

chengcheng-pei commented Jun 26, 2020

@adriangonz what do you mean by production settings? could you please give some details?

even if there is only one worker, I hope we can do production settings. but I have no idea what are these settings.
For one worker, whether to use gunicorn is not my concern.

@adriangonz
Copy link
Contributor Author

@chengcheng-pei the built-in Flask server is not really suited for production. Ideally we should use Gunicorn instead, even with a single worker.

The idea is to keep exposing the Flask server under a --debug flag, but default to Gunicorn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/p0 triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants