Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebooks test #1940

Merged
merged 3 commits into from
Jun 13, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jun 12, 2020

Follow-up to #1934 to fix notebooks tests.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: adriangonz

If they are not already assigned, you can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Jun 12 10:13:39 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=3

@seldondev
Copy link
Collaborator

Fri Jun 12 10:13:39 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=1

@seldondev
Copy link
Collaborator

Fri Jun 12 10:15:08 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=2

@seldondev seldondev added size/M and removed size/S labels Jun 12, 2020
@seldondev
Copy link
Collaborator

Fri Jun 12 10:33:46 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=5

@seldondev
Copy link
Collaborator

Fri Jun 12 10:33:58 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=4

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Jun 12 10:56:44 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=6

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Jun 12 12:34:04 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1940/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1940 --build=7

@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 4d398be link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ukclivecox
Copy link
Contributor

@adriangonz I think I will merge your changes as I think they make sense. If there are other bad notebook tests we can fix them in another PR

@ukclivecox ukclivecox merged commit 7edeb1d into SeldonIO:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants