Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart integration tests #1934

Merged
merged 5 commits into from
Jun 11, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jun 11, 2020

Fix issue introduced by #1906, which broke the seldon-single-model chart and some of the integration tests.

Changelog

  • Use right type for labels and annotations in chart
  • Use seldonio/fixed-model:0.1 on tests using seldon-single-model chart

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Jun 11 10:53:01 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1934/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1934 --build=2

@seldondev
Copy link
Collaborator

Thu Jun 11 10:53:34 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1934/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1934 --build=3

@seldondev
Copy link
Collaborator

Thu Jun 11 10:54:07 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1934/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1934 --build=1

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Jun 11 12:29:29 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1934/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1934 --build=4

@adriangonz
Copy link
Contributor Author

/cc @RafalSkolasinski @cliveseldon

@RafalSkolasinski
Copy link
Contributor

Nice one!
/approve

@seldondev seldondev merged commit 2bee32c into SeldonIO:master Jun 11, 2020
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz adriangonz deleted the fix-helm-integration branch June 11, 2020 14:53
@adriangonz adriangonz mentioned this pull request Jun 12, 2020
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 5df9a9f
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 5df9a9f
  • failed to process repo SeldonIO/seldon-core refref 5df9a9f
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants