-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add managed-by label #1937
add managed-by label #1937
Conversation
/test integration |
Thu Jun 11 16:22:17 UTC 2020 impatient try |
Thu Jun 11 16:28:50 UTC 2020 impatient try |
Thu Jun 11 16:28:52 UTC 2020 impatient try |
6b84f0a
to
88fe09c
Compare
Mon Jun 15 08:37:49 UTC 2020 impatient try |
Mon Jun 15 08:37:52 UTC 2020 impatient try |
When testing in KIND I'm finding that the label is not currently getting onto the Pod. It does get onto the service (the one on port 9000). I'm attempting to piggy-back on the labels for component type such as 'model' or 'router'. Those labels are likewise only appearing on the services and not pods. |
Oh the label is on the Deployment and just not on the Pod. Will try moving it into the spec section. |
Mon Jun 15 09:23:49 UTC 2020 impatient try |
Mon Jun 15 09:25:13 UTC 2020 impatient try |
It is coming through now. And services are still correctly matching to deployments as I'm able to make requests and get responses. |
Tue Jun 16 12:47:48 UTC 2020 impatient try |
Tue Jun 16 12:47:50 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Jun 16 18:36:16 UTC 2020 impatient try |
Tue Jun 16 18:36:24 UTC 2020 impatient try |
fixes #1936