Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add managed-by label #1936

Closed
ryandawsonuk opened this issue Jun 11, 2020 · 0 comments · Fixed by #1937
Closed

add managed-by label #1936

ryandawsonuk opened this issue Jun 11, 2020 · 0 comments · Fixed by #1937
Labels
triage Needs to be triaged and prioritised accordingly

Comments

@ryandawsonuk
Copy link
Contributor

Would like to follow kubernetes recommended labels. Some of those seem to overlap with our existing labels though so that's a bigger topic. Immediately it would be good to just add the managed-by label. That one would mean all pods and services created by the seldon operator could be matched with a single label. That would be useful, for example, for using with the prometheus operator and its PodMonitor and ServiceMonitor concepts.

@ryandawsonuk ryandawsonuk added the triage Needs to be triaged and prioritised accordingly label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant