Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses to Python images #1379

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Jan 28, 2020

Related to #1360

Changelog

  • Add tox environment to generate the licensing info using pip-licenses
  • Add generated licenses/license.txt and licenses/dep.csv to repo
  • Copy licenses explicitly on non-local s2i images

Notes

The pip-licenses tool generates the list of deps from the installed packages. To avoid a "dirty" local virtualenv (and pulling in licenses not required by seldon-core) I've added a tox env which generates the list.

@adriangonz
Copy link
Contributor Author

/cc @cliveseldon @gsunner

@seldondev
Copy link
Collaborator

Tue Jan 28 18:04:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=1

@seldondev
Copy link
Collaborator

Tue Jan 28 18:04:13 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=2

@axsaucedo
Copy link
Contributor

Nice! Lgtm from my side 👍

@axsaucedo
Copy link
Contributor

/test integration

1 similar comment
@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/test lint

@axsaucedo
Copy link
Contributor

/test all

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Feb 3 12:25:52 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=3

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Feb 4 21:53:01 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=4

@seldondev
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Feb 11 15:25:12 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=6

@seldondev
Copy link
Collaborator

Tue Feb 11 15:25:17 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=5

@seldondev
Copy link
Collaborator

Tue Feb 11 15:25:25 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=7

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Feb 11 16:51:57 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=8

@seldondev
Copy link
Collaborator

Tue Feb 11 16:51:58 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=9

@seldondev
Copy link
Collaborator

Tue Feb 11 16:52:56 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1379/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1379 --build=10

@seldondev seldondev merged commit b466a57 into SeldonIO:master Feb 11, 2020
@adriangonz adriangonz deleted the add-python-licenses branch February 12, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants