-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add licenses to Python images #1379
Conversation
/cc @cliveseldon @gsunner |
Tue Jan 28 18:04:01 UTC 2020 impatient try |
Tue Jan 28 18:04:13 UTC 2020 impatient try |
Nice! Lgtm from my side 👍 |
/test integration |
1 similar comment
/test integration |
/test lint |
/test all |
/test integration |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Feb 3 12:25:52 UTC 2020 impatient try |
/test integration |
Tue Feb 4 21:53:01 UTC 2020 impatient try |
5539287
to
565ebaf
Compare
New changes are detected. LGTM label has been removed. |
/test integration |
Tue Feb 11 15:25:12 UTC 2020 impatient try |
Tue Feb 11 15:25:17 UTC 2020 impatient try |
Tue Feb 11 15:25:25 UTC 2020 impatient try |
565ebaf
to
3ceb530
Compare
/test integration |
Tue Feb 11 16:51:57 UTC 2020 impatient try |
Tue Feb 11 16:51:58 UTC 2020 impatient try |
Tue Feb 11 16:52:56 UTC 2020 impatient try |
Related to #1360
Changelog
tox
environment to generate the licensing info usingpip-licenses
licenses/license.txt
andlicenses/dep.csv
to repos2i
imagesNotes
The
pip-licenses
tool generates the list of deps from the installed packages. To avoid a "dirty" local virtualenv (and pulling in licenses not required byseldon-core
) I've added atox
env which generates the list.