Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3rd party licences to Docker images #1360

Closed
ukclivecox opened this issue Jan 23, 2020 · 2 comments
Closed

Add 3rd party licences to Docker images #1360

ukclivecox opened this issue Jan 23, 2020 · 2 comments
Assignees
@ukclivecox
Milestone
1.1

Comments

@ukclivecox
Copy link
Contributor

No description provided.

@ukclivecox ukclivecox added the triage Needs to be triaged and prioritised accordingly label Jan 23, 2020
@ukclivecox ukclivecox added this to the 1.1 milestone Jan 23, 2020
@ukclivecox ukclivecox changed the title Add 3rd part licences to Docker images Add 3rd party licences to Docker images Jan 23, 2020
@ukclivecox
Copy link
Contributor Author

The engine already has licences:

seldon-core/engine/Dockerfile.mvn

Line 19 in 87fe3f9

COPY --from=builder /workspace/target/generated-resources /licenses/

@ukclivecox ukclivecox assigned ukclivecox and unassigned adriangonz Jan 24, 2020
@ukclivecox
Copy link
Contributor Author

Following instructions at https://github.com/kubeflow/testing/tree/master/py/kubeflow/testing/go-license-tools

@adriangonz adriangonz mentioned this issue Jan 24, 2020
Merged
@adriangonz adriangonz mentioned this issue Jan 28, 2020
Merged
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
None yet
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@adriangonz @ukclivecox