Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator 3rd party licences #1367

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Operator 3rd party licences #1367

merged 1 commit into from
Jan 24, 2020

Conversation

ukclivecox
Copy link
Contributor

No description provided.

@ukclivecox ukclivecox added this to the 1.1 milestone Jan 24, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 24 15:30:08 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1367/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1367 --build=1

@seldondev
Copy link
Collaborator

Fri Jan 24 15:30:12 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1367/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1367 --build=2

@adriangonz
Copy link
Contributor

Linking #1360 for visibility

@adriangonz
Copy link
Contributor

/approve

Looks great!

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 3b1e503 into SeldonIO:master Jan 24, 2020
@ukclivecox ukclivecox mentioned this pull request Feb 12, 2020
Closed
@ukclivecox ukclivecox deleted the 1360_3rdprty_licenses branch February 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangonz adriangonz Awaiting requested review from adriangonz

@gsunner gsunner Awaiting requested review from gsunner

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ukclivecox @seldondev @adriangonz