Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace print with logging in tests #1372

Closed
RafalSkolasinski opened this issue Jan 27, 2020 · 3 comments · Fixed by #1424
Closed

replace print with logging in tests #1372

RafalSkolasinski opened this issue Jan 27, 2020 · 3 comments · Fixed by #1424
Assignees
@RafalSkolasinski
Milestone
1.1

Comments

@RafalSkolasinski
Copy link
Contributor

Some tests, e.g. python/tests/test_router_microservice.py, are using print statements to ease debugging on failure.

It may be a good idea to replace them with proper logging.

(Though, personally I am not sure if there is much benefit from doing that for tests).
@RafalSkolasinski RafalSkolasinski added the triage Needs to be triaged and prioritised accordingly label Jan 27, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Jan 27, 2020
Merged
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Jan 31, 2020
@ukclivecox
Copy link
Contributor

Maybe just remove the print statements to make the tests cleaner. The error when the test fails with the name of the test should be enough in production.

@ukclivecox ukclivecox added this to the 1.1 milestone Jan 31, 2020
@RafalSkolasinski
Copy link
Contributor Author

Print statements will be removed via #1424 which will close this issue once merged.

@RafalSkolasinski
Copy link
Contributor Author

Adjusted to replacement with logger.info.

@RafalSkolasinski RafalSkolasinski mentioned this issue Feb 13, 2020
Merged
RafalSkolasinski added a commit that referenced this issue Feb 13, 2020
@RafalSkolasinski
Merge pull request #1424 from RafalSkolasinski/issue/1372
ed241b1 
Replace print with logging.info in python/tests. Closes #1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Replace print with logging.info in python/tests. Closes #1372
2 participants
@ukclivecox @RafalSkolasinski