allow route method to use metadata, closes #591 #1365

RafalSkolasinski · 2020-01-24T13:27:04Z

This is to close #591.

seldondev · 2020-01-24T13:28:15Z

Fri Jan 24 13:28:14 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=1

seldondev · 2020-01-24T13:28:27Z

Fri Jan 24 13:28:26 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=2

seldondev · 2020-01-24T13:36:53Z

Fri Jan 24 13:36:52 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=3

seldondev · 2020-01-24T13:37:01Z

Fri Jan 24 13:37:00 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=4

RafalSkolasinski · 2020-01-27T13:58:39Z

Fixed lint and rebased on master.
/test integration

seldondev · 2020-01-27T13:58:49Z

Mon Jan 27 13:58:48 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=6

seldondev · 2020-01-27T13:58:58Z

Mon Jan 27 13:58:57 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=5

seldondev · 2020-01-27T13:59:58Z

Mon Jan 27 13:59:57 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=7

adriangonz

Looks good @RafalSkolasinski! I just added a small comment, let me know what you think.

python/tests/test_router_microservice.py

axsaucedo

Looks good, just added comments to remove some print statements

python/tests/test_router_microservice.py

RafalSkolasinski · 2020-01-27T14:09:42Z

Looks good, just added comments to remove some print statements

Similar prints are present in other test methods. I was only following the flow of the test file.

seldondev · 2020-01-27T14:42:51Z

Mon Jan 27 14:42:50 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=9

seldondev · 2020-01-27T14:42:52Z

Mon Jan 27 14:42:51 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=8

RafalSkolasinski · 2020-01-27T14:45:01Z

@axsaucedo If I am suppose to remove prints, shall I remove them from the whole file?
I thought they're there by purpose for easier debugging.

RafalSkolasinski · 2020-01-27T15:29:00Z

/test integration

seldondev · 2020-01-27T15:30:24Z

Mon Jan 27 15:30:22 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=10

RafalSkolasinski · 2020-01-27T16:33:53Z

It seems I am getting my favourite error about failed istio deploy:

kubectl rollout status deployment.apps/istio-ingressgateway -n istio-system
Waiting for deployment "istio-ingressgateway" rollout to finish: 0 of 1 updated replicas are available...
error: deployment "istio-ingressgateway" exceeded its progress deadline
make: *** [Makefile:45: install_istio] Error 1

RafalSkolasinski · 2020-01-27T17:17:36Z

/test integration

seldondev · 2020-01-27T17:18:57Z

Mon Jan 27 17:18:56 UTC 2020
The logs for [integration] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=11

RafalSkolasinski · 2020-01-27T19:10:18Z

/test integration

seldondev · 2020-01-27T19:11:34Z

Mon Jan 27 19:11:33 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=12

RafalSkolasinski · 2020-01-28T12:13:12Z

/test integration

seldondev · 2020-01-28T12:14:27Z

Tue Jan 28 12:14:26 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=13

RafalSkolasinski · 2020-01-29T15:18:22Z

/test integration

RafalSkolasinski · 2020-02-11T11:26:28Z

Rebased on top of #1415 therefore temporary WIP.
/test integration

seldondev · 2020-02-11T11:26:58Z

Tue Feb 11 11:26:57 UTC 2020
The logs for [pr-build] [28] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/28.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=28

seldondev · 2020-02-11T11:27:10Z

Tue Feb 11 11:27:08 UTC 2020
The logs for [lint] [29] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/29.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=29

seldondev · 2020-02-11T11:27:41Z

Tue Feb 11 11:27:40 UTC 2020
The logs for [integration] [30] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/30.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=30

RafalSkolasinski · 2020-02-11T12:20:18Z

Current run failed on

============================= FAILURES ===================================
_________________ TestRollingHttp.test_rolling_update6[ambas] __________________
[gw0] linux -- Python 3.6.0 /usr/local/bin/python

self = <test_rolling_updates.TestRollingHttp object at 0x7fcf5faa7198>
namespace = 'test-rolling-update6-ambas', api_gateway = 'localhost:8003'

    def test_rolling_update6(self, namespace, api_gateway):
        if api_gateway == API_ISTIO_GATEWAY:
            retry_run(
                f"kubectl create -f ../resources/seldon-gateway.yaml -n {namespace}"
            )
        retry_run(f"kubectl apply -f ../resources/graph1svc.json -n {namespace}")
        wait_for_status("mymodel", namespace)
        wait_for_rollout("mymodel", namespace, expected_deployments=2)
        logging.warning("Initial request")
        r = initial_rest_request("mymodel", namespace, endpoint=api_gateway)
        assert r.status_code == 200
        assert r.json()["data"]["tensor"]["values"] == [1.0, 2.0, 3.0, 4.0]
        retry_run(f"kubectl apply -f ../resources/graph2svc.json -n {namespace}")
        r = initial_rest_request("mymodel", namespace, endpoint=api_gateway)
        assert r.status_code == 200
        assert r.json()["data"]["tensor"]["values"] == [1.0, 2.0, 3.0, 4.0]
        i = 0
        for i in range(100):
            r = rest_request_ambassador("mymodel", namespace, api_gateway)
>           assert r.status_code == 200
E           assert 504 == 200
E             -504
E             +200

RafalSkolasinski · 2020-02-11T13:03:42Z

/retest

seldondev · 2020-02-11T13:04:48Z

Tue Feb 11 13:04:47 UTC 2020
The logs for [integration] [31] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/31.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=31

RafalSkolasinski · 2020-02-11T14:16:01Z

@axsaucedo @adriangonz This finally passed integration tests!
Should be not touched and merged just after #1415.

@axsaucedo Changes requested by you will be handled by #1424.

RafalSkolasinski · 2020-02-11T15:24:12Z

As #1415 is merged into master I rebased on top of it.
There should be no code difference between current state and version that passed tests.

seldondev · 2020-02-11T15:25:13Z

Tue Feb 11 15:25:11 UTC 2020
The logs for [lint] [33] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/33.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=33

seldondev · 2020-02-11T15:26:51Z

Tue Feb 11 15:26:50 UTC 2020
The logs for [pr-build] [32] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/32.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=32

RafalSkolasinski · 2020-02-12T10:56:12Z

Just to test if tests will pass again (they already passed on this version of code).
/test integration

seldondev · 2020-02-12T10:57:20Z

Wed Feb 12 10:57:19 UTC 2020
The logs for [integration] [34] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/34.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=34

RafalSkolasinski · 2020-02-12T11:33:03Z

/retest

seldondev · 2020-02-12T11:34:13Z

Wed Feb 12 11:34:12 UTC 2020
The logs for [integration] [35] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1365/35.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1365 --build=35

RafalSkolasinski · 2020-02-12T12:43:41Z

@axsaucedo This PR passed integration tests for 2nd time! Let's merge it before it changes its mind again ; - )

ukclivecox · 2020-02-13T11:28:04Z

/approve

seldondev · 2020-02-13T11:28:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2021-05-13T10:17:49Z

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository SeldonIO/seldon-core for ref 2430c2a
failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 2430c2a
failed to process repo SeldonIO/seldon-core refref 2430c2a
failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
open /var/tmp/gitrepo660600678/.lighthouse
no such file or directory

RafalSkolasinski requested review from axsaucedo and adriangonz January 24, 2020 13:27

seldondev added the size/M label Jan 24, 2020

RafalSkolasinski mentioned this pull request Jan 24, 2020

Allow route method to use metadata #591

Closed

RafalSkolasinski changed the title ~~allow route method to be used metadata, closes #591~~ allow route method to use metadata, closes #591 Jan 24, 2020

adriangonz reviewed Jan 27, 2020

View reviewed changes

python/tests/test_router_microservice.py Show resolved Hide resolved

axsaucedo suggested changes Jan 27, 2020

View reviewed changes

python/tests/test_router_microservice.py Show resolved Hide resolved

python/tests/test_router_microservice.py Show resolved Hide resolved

seldondev assigned axsaucedo Jan 27, 2020

seldondev added the size/L label Feb 11, 2020

RafalSkolasinski changed the title ~~WIP: allow route method to use metadata, closes #591~~ allow route method to use metadata, closes #591 Feb 11, 2020

seldondev removed the do-not-merge/work-in-progress label Feb 11, 2020

RafalSkolasinski added 2 commits February 11, 2020 15:22

allow route method to use metadata, closes #591

76009b0

add test that checks model which route does not accept **kwargs

2430c2a

seldondev added size/M and removed size/L labels Feb 11, 2020

RafalSkolasinski requested a review from axsaucedo February 12, 2020 11:22

seldondev added the approved label Feb 13, 2020

RafalSkolasinski merged commit 5429945 into SeldonIO:master Feb 13, 2020

axsaucedo removed their assignment May 13, 2021

allow route method to use metadata, closes #591 #1365

allow route method to use metadata, closes #591 #1365

Conversation

RafalSkolasinski commented Jan 24, 2020 • edited Loading

seldondev commented Jan 24, 2020

seldondev commented Jan 24, 2020

seldondev commented Jan 24, 2020

seldondev commented Jan 24, 2020

RafalSkolasinski commented Jan 27, 2020

seldondev commented Jan 27, 2020

seldondev commented Jan 27, 2020

seldondev commented Jan 27, 2020

adriangonz left a comment

Choose a reason for hiding this comment

axsaucedo left a comment

Choose a reason for hiding this comment

RafalSkolasinski commented Jan 27, 2020

seldondev commented Jan 27, 2020

seldondev commented Jan 27, 2020

RafalSkolasinski commented Jan 27, 2020

RafalSkolasinski commented Jan 27, 2020

seldondev commented Jan 27, 2020

RafalSkolasinski commented Jan 27, 2020

RafalSkolasinski commented Jan 27, 2020

seldondev commented Jan 27, 2020

RafalSkolasinski commented Jan 27, 2020

seldondev commented Jan 27, 2020

RafalSkolasinski commented Jan 28, 2020

seldondev commented Jan 28, 2020

RafalSkolasinski commented Jan 29, 2020

RafalSkolasinski commented Feb 11, 2020

seldondev commented Feb 11, 2020

seldondev commented Feb 11, 2020

seldondev commented Feb 11, 2020

RafalSkolasinski commented Feb 11, 2020

RafalSkolasinski commented Feb 11, 2020

seldondev commented Feb 11, 2020

RafalSkolasinski commented Feb 11, 2020

RafalSkolasinski commented Feb 11, 2020

seldondev commented Feb 11, 2020

seldondev commented Feb 11, 2020

RafalSkolasinski commented Feb 12, 2020

seldondev commented Feb 12, 2020

RafalSkolasinski commented Feb 12, 2020

seldondev commented Feb 12, 2020

RafalSkolasinski commented Feb 12, 2020

ukclivecox commented Feb 13, 2020

seldondev commented Feb 13, 2020

seldondev commented May 13, 2021

RafalSkolasinski commented Jan 24, 2020 •

edited

Loading