Fix bug with version saving being overwritten on subsequent saves #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklaise
commented
Sep 17, 2021
| @@ -22,6 +22,7 @@ def default_meta() -> dict: | |||
| "type": [], | |||
| "explanations": [], | |||
| "params": {}, | |||
| "version": None, | |||
There was a problem hiding this comment.
This is not strictly necessary here but added it as it serves as a kind of high-level "schema".
jklaise
commented
Sep 17, 2021
| self.meta["name"] = self.__class__.__name__ | ||
| self.meta["version"] = __version__ |
There was a problem hiding this comment.
The version needs to be added here instead of in the default_meta because each explainer has it's own DEFAULT_META defined in api.defaults.
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 82.32% 82.32% -0.01%
==========================================
Files 76 76
Lines 10316 10315 -1
==========================================
- Hits 8493 8492 -1
Misses 1823 1823
|
ascillitoe
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
@jklaise I just tested this and it seems to work nicely i.e. not overwriting with runtime version, but still raising a warning (which is preferable in my opinion) instead of an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue found in SeldonIO/alibi-detect#236 (comment).