Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to metadata #339

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Sep 17, 2021

Fixes #236. Takes the same approach as SeldonIO/alibi#481.

@jklaise jklaise requested a review from ascillitoe September 17, 2021 15:57
@jklaise
Copy link
Contributor Author

jklaise commented Sep 17, 2021

It appears that due to the current tests of comparing the meta attribute directly to a literal dictionary, the literal dict would need to include "version": __version__ for every test.

It might be better to factor out these meta dictionaries and use them when initializing the detectors, though this would still necessitate including "version": __version__ for each one if we keep the same tests.

@jklaise
Copy link
Contributor Author

jklaise commented Sep 20, 2021

Latest commit adds __version__ entry to the metadata tests. This seemed to be the easiest way to fix the tests without doing any refactoring.

@ascillitoe ascillitoe merged commit ba5da6a into SeldonIO:master Sep 22, 2021
@ascillitoe
Copy link
Contributor

@jklaise, @arnaudvl: I've merged this, but a minor follow-up thought, do you think we should move the save/load instructions from "Getting started" to a separate "Saving and loading" page like in alibi? For consistency with alibi but also because I wonder if we could do with adding a warning about different alibi-detect versions like in alibi, and this would start to clutter the "Getting started" page?

@jklaise
Copy link
Contributor Author

jklaise commented Sep 22, 2021

Sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alibi-detect version to metadata
2 participants