Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added fontFamily and fontFamilyFallback support in MiraiTheme and MiraiTextStyle #205

Merged
merged 2 commits into from
Sep 14, 2023
Merged

feat: Added fontFamily and fontFamilyFallback support in MiraiTheme and MiraiTextStyle #205

merged 2 commits into from
Sep 14, 2023

Conversation

i-asimkhan
Copy link
Contributor

…nd MiraiTextStyle

Description

Added fontFamily and fontFamilyFallback support in MiraiTheme and MiraiTextStyle

Related Issues

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@i-asimkhan i-asimkhan self-assigned this Sep 13, 2023
divyanshub024
divyanshub024 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divyanshub024 divyanshub024 merged commit 76bb90a into main Sep 14, 2023
@divyanshub024 divyanshub024 deleted the asim/font-family-support branch September 14, 2023 10:43
@divyanshub024 divyanshub024 added this to the v0.6 milestone Sep 14, 2023
@divyanshub024 divyanshub024 mentioned this pull request Sep 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshub024 divyanshub024 divyanshub024 approved these changes

Assignees

@i-asimkhan i-asimkhan

Labels
feature
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@i-asimkhan @divyanshub024