Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for fontFamily in MiraiTheme #118

Closed
2 tasks
RodolfoSilva opened this issue May 5, 2023 · 7 comments · May be fixed by #172
Closed
2 tasks

feat: Add support for fontFamily in MiraiTheme #118

RodolfoSilva opened this issue May 5, 2023 · 7 comments · May be fixed by #172
Assignees
@i-asimkhan
Labels
feature
Milestone
v0.6

Comments

@RodolfoSilva
Copy link
Contributor

RodolfoSilva commented May 5, 2023 •
edited
Loading

Description

We need to provide support for custom fontFamily in the MiraiTheme.

Requirements

  • Allow set fontFamily
  • Allow set fontFamilyFallback

Additional Context

Maybe we could use Google Font to archive that or use fonts placed in the asset folder.
Also we should provide a way to define the fontFamilyFallback.

{
   'fontFamily' : 'Inter',
   'fontFamilyFallback': ['Roboto']
}
@loud-at-heart
Copy link
Contributor

@RodolfoSilva can I take up this task

@RodolfoSilva
Copy link
Contributor Author

Yes

@i-asimkhan
Copy link
Contributor

Any update on this @loud-at-heart

@loud-at-heart
Copy link
Contributor

loud-at-heart commented Jul 4, 2023 •
edited
Loading

@i-asimkhan Will provide an update by end of this week got stuck in some other work

@i-asimkhan i-asimkhan added this to the v0.6 milestone Jul 24, 2023
@i-asimkhan
Copy link
Contributor

Hey guys, do you mean Google fonts usage here by using google fonts package @divyanshub024 @RodolfoSilva

@RodolfoSilva
Copy link
Contributor Author

Hello @i-asimkhan, I mean fonts from the assets folder.

@i-asimkhan i-asimkhan mentioned this issue Jul 26, 2023
Open
7 tasks
@divyanshub024
Copy link
Contributor

Closed by #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i-asimkhan i-asimkhan

Labels
feature
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

feat: Added support for font family using fonts from assets and G-Fonts Securrency-OSS/mirai
4 participants
@RodolfoSilva @i-asimkhan @divyanshub024 @loud-at-heart