Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GRPackage extensions on packages other than latest Pharo #1441

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jbrichau
Copy link
Member

Fixing issue reported in GsDevKit/Grease#32

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.42%. Comparing base (1523181) to head (8e55f94).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   49.39%   49.42%   +0.02%     
==========================================
  Files        9078     9073       -5     
  Lines       80126    80080      -46     
==========================================
  Hits        39576    39576              
+ Misses      40550    40504      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit f0dc0e9 into master Aug 13, 2024
24 of 28 checks passed
@jbrichau jbrichau deleted the grpackage-removal branch August 13, 2024 09:24
dalehenrich added a commit to GsDevKit/Grease that referenced this pull request Aug 13, 2024
…is no longer necessary ..revert "Issue #32: wire out the GRPackageTest>>testPackages test. The test fails in the presence of Seaside since, Seaside doesn't define the 'required methods' anymore"

This reverts commit 12d2cf1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant