Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The most recent version of Seaside no longer uses/supports GRPackge class #32

Closed
dalehenrich opened this issue Aug 12, 2024 · 1 comment
Closed

The most recent version of Seaside no longer uses/supports GRPackge class #32

dalehenrich opened this issue Aug 12, 2024 · 1 comment

Comments

@dalehenrich
Copy link
Member

The Grease test GRPackageTest >> #testPackages has started failing in internal tests and it seems that the Seaside extensions expected by that test are no longer provided by the most recent version of Seaside.

GRPackageTest >> #testPackages is the only test failure that we've seen ... and it fails when loaded against extent0.seaside.dbf (for GemStone 3.7.1.3) in internal tests ...

GsDevKit_stones/smalltalkCI tests are running fine, so the changes that I make will likely only affect the internal tests ...
dalehenrich added a commit that referenced this issue Aug 12, 2024
@dalehenrich
Issue #32: wire out the GRPackageTest>>testPackages test. The test fa…
12d2cf1 
…ils in the presence of Seaside since, Seaside doesn't define the 'required methods' anymore
@dalehenrich dalehenrich changed the title The most recent version of Seside no longer uses/supports GRPackge class The most recent version of Seaside no longer uses/supports GRPackge class Aug 13, 2024
@jbrichau jbrichau mentioned this issue Aug 13, 2024
Merged
@jbrichau
Copy link
Member

I think this should be fixed now...

dalehenrich added a commit that referenced this issue Aug 13, 2024
@dalehenrich
With this fix to Seaside (SeasideSt/Seaside#1441), the patch for #32 …
02e0f27 
…is no longer necessary ..revert "Issue #32: wire out the GRPackageTest>>testPackages test. The test fails in the presence of Seaside since, Seaside doesn't define the 'required methods' anymore"

This reverts commit 12d2cf1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dalehenrich @kurtkilpela @jbrichau