This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Fetch upstream changes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac757fa.
Co-authored-by: Peter Glotfelty <[email protected]>
…thub.com/Peternator7/strum into fetch-upstream-changes
This was referenced Mar 2, 2023
billy1624
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Hey @sergeiivankov, thanks for contributing!!
LGTM! It's time to pull the changes from the upstream.
P.S. @tyt2y3 I think we can merge and publish this to crates.io before the SeaORM 0.12.0 is released.
|
Actually, I wish we can avoid using a forked version. |
|
Thank you for the contribution. I did:
So I'd close this PR now. |
Maybe there is a way allowing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related with SeaQL/sea-schema#103 and SeaQL/sea-orm#1520