Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional filters #92

Closed
wants to merge 4 commits into from
Closed

Conversation

hgiesel
Copy link

@hgiesel hgiesel commented Nov 6, 2022

Adds more filters. I've allowed them for all types, because sea-orm also allows them on all columns (and they produce valid SQL).
The filters do not actually work on some types, like datetime, but it's still valid SQL.

PR Info

New Features

  • Allow more filters on types:
    • starts_with
    • ends_with
    • contains
    • like
    • not_like

@karatakis
Copy link
Collaborator

@hgiesel this works great for sqlite that does not support Enums. But for MySQL and PostgreSQL there is a different story. I will study how we can do a workaround for this. I will look to solve filter in a different approach. This issue is related #87

@karatakis karatakis mentioned this pull request Nov 8, 2022
2 tasks
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hgiesel @karatakis, I think those filters has been added on #97

@billy1624 billy1624 marked this pull request as draft November 11, 2022 08:24
@karatakis
Copy link
Collaborator

@billy1624 yeah. @hgiesel thanks for the effort.

@karatakis karatakis closed this Nov 11, 2022
@skopz356
Copy link
Contributor

skopz356 commented Jan 17, 2023

Hey @hgiesel @karatakis, I think those filters has been added on #97

No they were not, https://github.com/SeaQL/seaography/pull/97/files#diff-b3bd7a19de11305fd016d84192a730c0bc2fdadf6015f71bd4ad4a39bf798a0dR158, there is not implemention for:

  • starts_with
  • ends_with
  • contains
  • like
  • not_like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

StringFilter should support LIKE
4 participants