A generic filter for any types and database enums

[billy1624]

Why?

Currently we depends on this list of types to differentiate "built in" type from database enum. I think this is hard to maintain and adding new "built in" type requires changing two places. Adding a derive attribute to TypeFilter and append the new type to the list below.

seaography/derive/src/filter.rs

Lines 53 to 98 in 39ced31

	let default_filters = vec![
	"String",
	"i8",
	"i16",
	"i32",
	"i64",
	"u8",
	"u16",
	"u32",
	"u64",
	"f32",
	"f64",
	#[cfg(feature = "with-chrono")]
	"Date",
	#[cfg(feature = "with-chrono")]
	"DateTime",
	#[cfg(feature = "with-chrono")]
	"DateTimeUtc",
	#[cfg(feature = "with-chrono")]
	"DateTimeWithTimeZone",
	#[cfg(feature = "with-decimal")]
	"Decimal",
	#[cfg(feature = "with-json")]
	"Json",
	#[cfg(feature = "with-uuid")]
	"Uuid",
	"BinaryVector",
	"bool",
	];
	let filter_item = if default_filters.contains(&type_literal.as_str())
	|| type_literal.starts_with("Vec")
	{
	quote! {
	seaography::TypeFilter<#ty>
	}
	} else {
	let ident = format_ident!("{}EnumFilter", type_literal);
	quote! {
	crate::entities::sea_orm_active_enums::#ident
	}
	};
	quote! {
	#ident: Option<#filter_item>
	}

Solution?

I think we could introduce a new trait with getter method for all the "built in" types and database enums.

pub struct FilterTrait {
    type Ty:

    fn eq(&self) -> Option<Self::Ty>;
    fn ne(&self) -> Option<Self::Ty>;
    fn gt(&self) -> Option<Self::Ty>;
    fn gte(&self) -> Option<Self::Ty>;
    fn lt(&self) -> Option<Self::Ty>;
    fn lte(&self) -> Option<Self::Ty>;
    fn is_in(&self) -> Option<Vec<Self::Ty>>;
    fn is_not_in(&self) -> Option<Vec<Self::Ty>>;
    fn is_null(&self) -> Option<bool>;
}

Then, we can write this as #ident: Option<FilterTrait<Ty = #type_ident>>

• seaography/derive/src/filter.rs

  Lines 96 to 98 in 39ced31

  	quote! {
  	#ident: Option<#filter_item>
  	}

Thoughts? @karatakis

[tyt2y3]

Sounds like a brilliant idea