-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema Manager #26
Schema Manager #26
Conversation
I ignored the schema iden in sea-schema/src/mysql/query/table.rs Lines 52 to 81 in 16194d1
|
2092ec9
to
152d1e5
Compare
7c31e14
to
1b0eb31
Compare
ooops. it does not seem to work :( |
|
Try cherrypick 0929661 |
5742d47
to
12273bf
Compare
9696ec3
to
c7ad70e
Compare
okay so it's completely broken now |
c7ad70e
to
9696ec3
Compare
I think we got a very problematic dependency tree here. As a rule-of-thumb, sea-schema should not directly depends on sea-orm. We might want to split out |
9b7b7d6
to
ec63a04
Compare
ec63a04
to
9be9207
Compare
Okay so the culprit is that sea-orm and sea-schema each has a dependency on sea-query, currently stuck in a deadlock, and there is no way to upgrade one side without breaking the other side. We definitely have to re-architect this before releasing. The problem is the API exposed sea-query symbols and that tied things together. Ideally, sea-schema should be able to use a different sea-query version internally from sea-orm without causing trouble. The migrator should use the sea-query |
Merge to master for now. Note that sea-query is still stuck at 0.20, and we definitely want to upgrade to 0.21. |
PR Info
TableRef::DatabaseSchemaTable
sea-query#193TableRef
for all databases sea-query#202