Migration #335

billy1624 · 2021-11-26T08:27:40Z

PR Info

Resolve Migration Supports #333
Depends on Schema Manager sea-schema#26

src/database/transaction.rs

tyt2y3 · 2022-01-30T03:56:36Z

src/database/transaction.rs

@@ -345,10 +349,17 @@ impl<'a> ConnectionTrait<'a> for DatabaseTransaction {
            }
            #[cfg(feature = "mock")]
            InnerConnection::Mock(conn) => return conn.query_all(stmt),
+            #[allow(unreachable_patterns)]
+            _ => unreachable!(),


why is it needed here?

sea-schema depends on sea-orm because it needs the symbol to compile. It's up to the end-user to decide which backend they want to enable. So, it's defined as below, but this won't compile because it requires at least one backend / mock feature to be selected.

sea-orm = { git = "https://github.com/SeaQL/sea-orm.git", branch = "migration", default-features = false, features = ["macros"], optional = true }

https://github.com/SeaQL/sea-schema/blob/3309d13819ae8b2d58dcf4ebbd4cb1936a7f8f15/Cargo.toml#L40

okay if we actually figured a way of building sea-orm without any backend, it's good! It could have resolved #438 (comment) as a side effect?

* Refactor `ConnectionTrait` * Refactoring * Build index & foreign key statements * Fix imports * Fixup * Rocket example with migration * async-std compatible with the tokio 1.0 runtime * Use reexported dependency * Compile without selecting any db backend * Updating sea-orm-cli dep * sea-orm-cli migrate commands * cargo fmt * Test [cli] * Refactoring * Clap app name should be "sea-orm-cli" * Correctly capture MIGRATION_DIR * Rename README * Add `sea-orm-cli migrate init` command * Update README * Try restructured sea-query dependency (SeaQL/sea-schema#41) * Set `DATABASE_URL` environment variable

* Add Poem example * Name conflict of foreign key constraints when two entities have more than one foreign keys (#417) * fix: name conflict of foreign key constraints when two entities have more than one fk * test: update test case's foreign keys * feat: override default name of foreign key constraint * Add `max_lifetime` connection option * Remove `r#` prefix from column name when field has a raw identifier * Fix FromQueryResult when Result is redefined Macros should only ever use absolute import paths. Shorthands can clash (as they have in my case). * Support the use of chrono::DateTime<Utc> in sea-orm Add documentation for this Temporarily use a fork to include new Sea-query code Add tests for DateTimeUtc Solve Github actions error by add the code to create a table Assertion accuracy tests Rectify incorrect format * Refactoring `ColumnDef` with default value Cargo fmt Update docs Fixup Support `DateTimeLocal` Update docs Codegen write db timestamp column as `DateTimeUtc` type Update dependency Merge branch 'sea-query/add-new-column-ref' into pr/429 feat: apply alias on `ColumnRef::SchemaTableColumn` * Update sea-query dependency * Fully quantity `std::result::Result` in proc_maros * Migration (#335) * Refactor `ConnectionTrait` * Refactoring * Build index & foreign key statements * Fix imports * Fixup * Rocket example with migration * async-std compatible with the tokio 1.0 runtime * Use reexported dependency * Compile without selecting any db backend * Updating sea-orm-cli dep * sea-orm-cli migrate commands * cargo fmt * Test [cli] * Refactoring * Clap app name should be "sea-orm-cli" * Correctly capture MIGRATION_DIR * Rename README * Add `sea-orm-cli migrate init` command * Update README * Try restructured sea-query dependency (SeaQL/sea-schema#41) * Set `DATABASE_URL` environment variable * Fix sea-schema dependency * Codegen `column_name` proc_macro attribute (#433) * feat: codegen `column_name` proc_macro attribute * test: codegen `column_name` * Temporary fix * Fix sea-orm dependency * Insert Default - Inserting `ActiveModel` with all attributes `NotSet` (#432) * feat: apply alias on `ColumnRef::SchemaTableColumn` * build: update sea-query dependency * feat: insert default * Use sea-query 0.21 Co-authored-by: Billy Chan <[email protected]> * Easy joins with MockDatabase #447 (#455) * Easy joins with MockDatabase #447 * fix MR * add unit test * Add test cases * Cargo fmt Co-authored-by: Bastian Schubert <[email protected]> Co-authored-by: Billy Chan <[email protected]> Co-authored-by: Chris Tsang <[email protected]> * cargo fmt * Revert "Insert Default - Inserting `ActiveModel` with all attributes `NotSet` (#432)" This reverts commit 33a87d7. * Prepare release * sea-orm-codegen 0.6.0 * sea-orm-cli 0.6.0 * sea-orm-macros 0.6.0 * 0.6.0 * Optimize GitHub actions * Update examples sea-orm version Update example sea-schema version Update [cli] sea-schema version * Fix [cli] cargo publish failed * Update CHANGELOG * Use sea-schema 0.5.1 * use sea_schema::migration::prelude * Use caret requirements * Fix build error * Examples with migration (#509) * Update examples sea-orm version * Update example sea-schema version * Update [cli] sea-schema version * Fix [cli] cargo publish failed * Update CHANGELOG * Edit rocket example * Poem example with migration * Axum example with migration * Refactoring * Actix4 example with migration * Actix example with migration * Use sea_schema::migration::prelude Co-authored-by: Sunli <[email protected]> Co-authored-by: Billy Chan <[email protected]> Co-authored-by: Billy Chan <[email protected]> Co-authored-by: Szepesi Tibor <[email protected]> Co-authored-by: Tom Hacohen <[email protected]> Co-authored-by: Charles Chege <[email protected]> Co-authored-by: Bastian <[email protected]> Co-authored-by: Bastian Schubert <[email protected]>

billy1624 self-assigned this Nov 26, 2021

billy1624 mentioned this pull request Nov 26, 2021

Schema Manager SeaQL/sea-schema#26

Merged

tyt2y3 force-pushed the master branch 7 times, most recently from bc75b4b to e7d7962 Compare December 25, 2021 17:00

billy1624 added 4 commits January 17, 2022 12:19

Refactor ConnectionTrait

2dcfe40

Refactoring

ea74fca

Build index & foreign key statements

f0997ff

Fix imports

bff98b5

billy1624 force-pushed the migration branch from a517e9d to b29513b Compare January 18, 2022 06:48

Fixup

e42d58b

billy1624 force-pushed the migration branch from b29513b to e42d58b Compare January 18, 2022 06:59

Rocket example with migration

1948720

billy1624 marked this pull request as ready for review January 20, 2022 09:56

billy1624 added 2 commits January 20, 2022 18:12

async-std compatible with the tokio 1.0 runtime

9616c8a

Use reexported dependency

a9092aa

billy1624 mentioned this pull request Jan 24, 2022

Where does a TableCreateStatement go? #478

Closed

Compile without selecting any db backend

f7f1c4b

billy1624 force-pushed the migration branch from 91808ee to f7f1c4b Compare January 28, 2022 07:31

billy1624 added 7 commits January 28, 2022 15:41

Updating sea-orm-cli dep

ca4a336

sea-orm-cli migrate commands

98d4131

cargo fmt

b00c02a

Test [cli]

f844016

Refactoring

8abc8e0

Clap app name should be "sea-orm-cli"

8a41034

Correctly capture MIGRATION_DIR

a6ee07a

billy1624 added 3 commits January 28, 2022 19:29

Rename README

48fcc97

Add sea-orm-cli migrate init command

036939e

Update README

603b0ef

billy1624 requested a review from tyt2y3 January 28, 2022 12:44

tyt2y3 reviewed Jan 30, 2022

View reviewed changes

src/database/transaction.rs Show resolved Hide resolved

tyt2y3 reviewed Jan 30, 2022

View reviewed changes

tyt2y3 force-pushed the migration branch from 4e10405 to 603b0ef Compare February 2, 2022 03:04

Try restructured sea-query dependency (SeaQL/sea-schema#41)

1770ce3

billy1624 force-pushed the migration branch from 6955f10 to 1770ce3 Compare February 3, 2022 14:23

Set DATABASE_URL environment variable

41679c4

tyt2y3 merged commit 8d0364d into master Feb 5, 2022

tyt2y3 deleted the migration branch February 5, 2022 12:32

This was referenced Apr 25, 2022

fix(deps): update rust crate sea-orm to 0.12 - autoclosed duskmoon314/LoD-backend#3

Closed

fix(deps): update rust crate sea-orm to 0.10.5 IgnisDa/developrs#12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration #335

Migration #335

billy1624 commented Nov 26, 2021 •

edited

Loading

tyt2y3 Jan 30, 2022

billy1624 Jan 30, 2022 •

edited

Loading

tyt2y3 Feb 2, 2022

Migration #335

Migration #335

Conversation

billy1624 commented Nov 26, 2021 • edited Loading

PR Info

tyt2y3 Jan 30, 2022

Choose a reason for hiding this comment

billy1624 Jan 30, 2022 • edited Loading

Choose a reason for hiding this comment

tyt2y3 Feb 2, 2022

Choose a reason for hiding this comment

billy1624 commented Nov 26, 2021 •

edited

Loading

billy1624 Jan 30, 2022 •

edited

Loading