Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set unselected Column of type Option<T> to None #1513

Merged
merged 6 commits into from
Mar 16, 2023
Merged

set unselected Column of type Option<T> to None #1513

merged 6 commits into from
Mar 16, 2023

Conversation

Reverier-Xu
Copy link
Contributor

PR Info

  • Dependencies:
    • none
  • Dependents:
    • none

New Features

  • Support for filling None on Column of type Option<T> which is not selected instead of throwing an error.

Changes

  • Added a branch judgment in impl TryGetable for Option<T>

@Reverier-Xu Reverier-Xu marked this pull request as draft February 28, 2023 06:15
@Reverier-Xu Reverier-Xu marked this pull request as ready for review February 28, 2023 06:20
@Reverier-Xu Reverier-Xu changed the title Support None value for unselected Optional columns set unselected Column of type Option<T> to None Feb 28, 2023
src/executor/query.rs Outdated Show resolved Hide resolved
@Reverier-Xu Reverier-Xu requested a review from billy1624 March 7, 2023 04:19
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
This is a small change, but with a bigger implication.
So we would need to document this as a breaking behavioural change.
All CI seems to pass, so hopefully it did not violate any assumption.

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @Reverier-Xu

@billy1624 billy1624 merged commit 1161bc0 into SeaQL:master Mar 16, 2023
darkmmon added a commit to darkmmon/seaql.github.io that referenced this pull request Jul 11, 2023
billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Jul 19, 2023
* Optional Field SeaQL/sea-orm#1513

* .gitignore SeaQL/sea-orm#1334

* migration table custom name SeaQL/sea-orm#1511

* OR condition relation SeaQL/sea-orm#1433

* DerivePartialModel SeaQL/sea-orm#1597

* space for migration file naming SeaQL/sea-orm#1570

* composite key up to 12 SeaQL/sea-orm#1508

* seaography integration SeaQL/sea-orm#1599

* QuerySelect SimpleExpr SeaQL/sea-orm#1702

* sqlErr SeaQL/sea-orm#1707

* migration check SeaQL/sea-orm#1519

* postgres array SeaQL/sea-orm#1565

* param intoString SeaQL/sea-orm#1439

* **skipped** re-export SeaQL/sea-orm#1661

* ping SeaQL/sea-orm#1627

* on empty do nothing SeaQL/sea-orm#1708

* on conflict do nothing SeaQL/sea-orm#1712

* **skipped** upgrade versions

* active enum fail safe SeaQL/sea-orm#1374

* relation generation check SeaQL/sea-orm#1435

* entity generation bug SeaQL/sea-schema#105

* **skipped** bug fix that does not require edits

* EnumIter change SeaQL/sea-orm#1535

* completed and fixed a previous todo SeaQL/sea-orm#1570

* amended wordings and structures

* Edit

* Remove temp file

---------

Co-authored-by: Billy Chan <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 Released In 0.12.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants