Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close connection explicitly #1236

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Close connection explicitly #1236

merged 2 commits into from
Nov 22, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Nov 21, 2022

New Features

  • Adds close method to close connection explicitly. (Note: it will be automatically closed when it goes out of scope without closing it explicitly.)

@billy1624 billy1624 self-assigned this Nov 21, 2022
@billy1624 billy1624 marked this pull request as ready for review November 21, 2022 03:25
@tyt2y3
Copy link
Member

tyt2y3 commented Nov 21, 2022

I don't think this method can be put in the ConnectionTrait, for the fact that Pool::close and Transaction::close do completely different things, where Pool::close is basically "good bye".

We can simply add a rollback method to Transaction.

@billy1624 billy1624 changed the title Close connection and transaction explicitly Close connection explicitly Nov 21, 2022
@billy1624
Copy link
Member Author

billy1624 commented Nov 21, 2022

Clearly I went too far. We should just add a method to close DatabaseConnection, that'd be enough.

@billy1624 billy1624 requested a review from tyt2y3 November 21, 2022 09:46
@tyt2y3 tyt2y3 merged commit 115e19a into master Nov 22, 2022
@tyt2y3 tyt2y3 deleted the close-connection branch November 22, 2022 05:55
@billy1624 billy1624 added this to the 0.11.x milestone Jan 31, 2023
billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Feb 3, 2023
tyt2y3 added a commit to SeaQL/seaql.github.io that referenced this pull request Feb 3, 2023
* Update 02-writing-migration.md

* Update SeaORM/docs/03-migration/02-writing-migration.md

* Support various UUID formats that are available in `uuid::fmt` module (SeaQL/sea-orm#1325)

* Casting columns as a different data type on select, insert and update (SeaQL/sea-orm#1304)

* Methods of `ActiveModelBehavior` receive db connection as a parameter (SeaQL/sea-orm#1145, SeaQL/sea-orm#1328)

* Added `execute_unprepared` method to `DatabaseConnection` and `DatabaseTransaction` (SeaQL/sea-orm#1327)

* Added `Select::into_tuple` to select rows as tuples (instead of defining a custom Model) (SeaQL/sea-orm#1311)

* Generate `#[serde(skip)]` for hidden columns (SeaQL/sea-orm#1171, SeaQL/sea-orm#1320)

* Generate entity with extra derives and attributes for model struct (SeaQL/sea-orm#1124, SeaQL/sea-orm#1321)

* Generate entity with extra derives and attributes for model struct (SeaQL/sea-orm#1124, SeaQL/sea-orm#1321)

* async_trait

* Migrations are now performed inside a transaction for Postgres (SeaQL/sea-orm#1379)

* `MockDatabase::append_exec_results()`, `MockDatabase::append_query_results()`, `MockDatabase::append_exec_errors()` and `MockDatabase::append_query_errors()` take any types implemented `IntoIterator` trait (SeaQL/sea-orm#1367)

* Cleanup the use of `vec!` macros

* Added `DatabaseConnection::close` (SeaQL/sea-orm#1236)

* Added `ActiveValue::reset` to convert `Unchanged` into `Set` (SeaQL/sea-orm#1177)

* Added `QueryTrait::apply_if` to optionally apply a filter (SeaQL/sea-orm#1415)

* Added the `sea-orm-internal` feature flag to expose some SQLx types (SeaQL/sea-orm#1297, SeaQL/sea-orm#1434)

* Add `QuerySelect::columns` method - select multiple columns (SeaQL/sea-orm#1264)

* Edit

* Update SeaORM/docs/02-install-and-config/02-connection.md

Co-authored-by: Chris Tsang <[email protected]>

* Update SeaORM/docs/05-basic-crud/03-insert.md

Co-authored-by: Chris Tsang <[email protected]>

* fmt

* Edit

---------

Co-authored-by: Chris Tsang <[email protected]>
@tyt2y3 tyt2y3 mentioned this pull request May 16, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants