Unchanged ActiveValue as Set

[billy1624]

PR Info

New Features

• Converting Unchanged active value as Set

[tyt2y3]

Umm I think there might be more self-explanatory method names

[billy1624]

Agree! Let me brainstorm it tonight in dream.
Any other naming suggestions are welcomed!

[billy1624]

How about unchanged_value_into_set?

[billy1624]

Okay, renamed

[tyt2y3]

I think we should instead only add two methods to ActiveModel: iter and iter_mut.
And then the user can do:

active_model.iter_mut(|(_col, &mut val)| {
    *val = match val {
        ActiveValue::Unchanged(v) => ActiveValue::Set(v),
        _ => (),
    };
});

[billy1624]

Let user perform the conversion on their own?

[billy1624]

We just provide a API to effortlessly iterate all fields in the ActiveModel.

And we should include a code snippet in the cookbook on how to update all Unchanged fields into Set

[tyt2y3]

May we could have a rechange method on ActiveValue:

active_model.iter_mut(|(_col, &mut val)| {
    *val = val.rechange();
});

Still a bad name though

[billy1624]

I don't think we can have

active_model.iter_mut(|(_col, &mut val: ActiveValue<V>)| {
    *val = match val {
        ActiveValue::Unchanged(v) => ActiveValue::Set(v),
        _ => (),
    };
});

Because it's impossible to have &mut val: ActiveValue<V> where V: Into<Value>.

We can have &mut val: ActiveValue<i32> but then we can't iterate over the columns.

[tyt2y3]

Ah I see what you mean, sad :(

[billy1624]

Back to the naming problem. How about set_dirty?

Nice editing @tyt2y3

[billy1624]

Any opinion on the naming? @tyt2y3

[tyt2y3]

Back to square 1, can we have reset and reset_all?

[billy1624]

Renamed :D