Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/reconfigure test deployments #84

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

alexkeating
Copy link
Collaborator

Description

  • Deploy working bridging for both comp and no comp
  • Change quoteEvmDelivery to a view function
  • Update how chain initialization works

* Deploy to Goerli and Optimism Goerli
* Add missing sample environment variables
@alexkeating alexkeating force-pushed the bug/reconfigure-test-deployments branch from fd292fa to 4663381 Compare October 17, 2023 18:46
@alexkeating
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

Coverage after merging bug/reconfigure-test-deployments into main will be

98.52%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   L1VotePool.sol100%100%100%100%
   L2GovernorMetadata.sol100%100%100%100%
   L2VoteAggregator.sol93.98%86.36%100%95.56%145, 217, 259, 262, 265
   WormholeL1ERC20Bridge.sol96.15%83.33%100%100%78
   WormholeL1GovernorMetadataBridge.sol100%100%100%100%
   WormholeL1VotePool.sol100%100%100%100%
   WormholeL2ERC20.sol95.65%75%100%100%96
   WormholeL2GovernorMetadata.sol100%100%100%100%
   WormholeL2VoteAggregator.sol100%100%100%100%
   WormholeReceiver.sol100%100%100%100%
   WormholeSender.sol100%100%100%100%
src/optimized
   WormholeL2GovernorMetadataOptimized.sol100%100%100%100%
   WormholeL2VoteAggregatorCalldataCompressor.sol97.30%91.67%100%100%87

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexkeating alexkeating merged commit 1fca33b into main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants