Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to Goerli and Optimism Goerli #80

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Oct 10, 2023

Description

  • Add configuration for goerli and optimism goerli

Closes #79

@alexkeating alexkeating mentioned this pull request Oct 10, 2023
@alexkeating alexkeating marked this pull request as ready for review October 10, 2023 20:31
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a couple small things that shouldnt block merge

test/Constants.sol Show resolved Hide resolved
test/Constants.sol Show resolved Hide resolved
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexkeating alexkeating force-pushed the feature/find-test-gaps branch from f1ee4c4 to 4461e27 Compare October 11, 2023 19:37
@alexkeating alexkeating force-pushed the feature/support-other-testnets branch 3 times, most recently from 2732b80 to 1b671e8 Compare October 11, 2023 19:52
@apbendi apbendi force-pushed the feature/find-test-gaps branch from 36fdc6c to e4df2f6 Compare October 12, 2023 01:12
@alexkeating alexkeating changed the base branch from feature/find-test-gaps to main October 12, 2023 13:11
@alexkeating alexkeating force-pushed the feature/support-other-testnets branch from 1b671e8 to bf6ccf8 Compare October 12, 2023 13:11
@alexkeating alexkeating merged commit a0c4156 into main Oct 12, 2023
@github-actions
Copy link

Coverage after merging feature/support-other-testnets into feature/find-test-gaps will be

98.52%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   L1VotePool.sol100%100%100%100%
   L2GovernorMetadata.sol100%100%100%100%
   L2VoteAggregator.sol93.98%86.36%100%95.56%145, 217, 259, 262, 265
   WormholeL1ERC20Bridge.sol96.15%83.33%100%100%78
   WormholeL1GovernorMetadataBridge.sol100%100%100%100%
   WormholeL1VotePool.sol100%100%100%100%
   WormholeL2ERC20.sol95.65%75%100%100%96
   WormholeL2GovernorMetadata.sol100%100%100%100%
   WormholeL2VoteAggregator.sol100%100%100%100%
   WormholeReceiver.sol100%100%100%100%
   WormholeSender.sol100%100%100%100%
src/optimized
   WormholeL2GovernorMetadataOptimized.sol100%100%100%100%
   WormholeL2VoteAggregatorCalldataCompressor.sol97.30%91.67%100%100%87

alexkeating added a commit that referenced this pull request Oct 17, 2023
* Deploy to Goerli and Optimism Goerli
* Add missing sample environment variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contracts to support other testnets
3 participants