-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paul/FREYA-746 #1162
Paul/FREYA-746 #1162
Conversation
Ziip-dev
commented
Jul 22, 2024
•
edited
Loading
edited
- Add last updated date to dashboard cards
- Reorder dashboard cards by most recent update date
- Add filter menu to the dashboard index page
- Display the three most recently updated dashboards on the homepage
- Display the three most recently updated dashboards on the topics pages
- Get dashboard file URL path in Hugo template - Add a <div> element with the necessary paging classes - Add a <span> element with an 'id' property to easily address the different dashboard cards
1abcd9d
to
9d28a61
Compare
Just to make it clear, I remove the list of dashboards to be displayed in the homepage from the dashboard template. It's not super elegant, but this is the solution that required the least amount of modifications or special conditions... At the end it falls under the top banner short "flicker", so not more noticeable than that. |
Same goes for the topic pages as the same script is used |
This script: - reads the EBI index json file from blobserver containing the dashboard data - iterates over the dashboard cards in the HTML - finds the matching entries in the EBI data - handles special cases where there is no exact matching entry - parses the retrieved corresponding data and write it in the dashboard card
c914433
to
e83a78b
Compare
All done @senthil10, if you want to give it one last final check |
- Add date ordering logic to script.
This metadata defines if the dashboard page is either still regularly updated or historic.
e83a78b
to
62d87cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, looks good to me. If @LianeHughes is also happy, it can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made an update to the text on GU's dashboard (to make it consistent with KTH and to ensure that users are pointed to relevant data, as is also done elsewhere). I noticed that multi-disease is missing and some dates are incorrect. I assume that's because it requires the EBI file update?
If possible, the Swedish version titles for all, updating, and historic should be changed to 'allt' 'uppdaterad' and 'historisk'
Modify script to also display the three most recently updated dashboard cards on the topic pages.
f8c812f
to
3032c8c
Compare
Translation for filter labels added. |