Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abspath instead of resolve #175

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Conversation

alneberg
Copy link
Contributor

Resolve would a source link to be uploaded with the name of what the link is pointing to and not the name of the link. I think the name of the link is what we should have.

A good test case is the following structure:

mkdir dir_with_contents
touch dir_with_contents/simple_file.txt
ln -s dir_with_contents dir_that_is_a_link
dds put -u unituser_1 -p project_1 -s dir_that_is_a_link
dds get -u unituser_1 -p project_1 -a

Prior to this PR the downloaded data would be inside files/dir_with_contents and after this PR it would be files/dir_that_is_a_link.

@alneberg alneberg requested review from i-oden and aanil October 18, 2021 13:34
@alneberg alneberg mentioned this pull request Oct 18, 2021
resolved = path.resolve()
except RuntimeError:
LOG.warning(
f"IGNORED: Link: {path} seems to contain infinite loop, will be ignored."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@i-oden i-oden merged commit 69a01d7 into ScilifelabDataCentre:dev Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants