Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File link handling #119

Closed
i-oden opened this issue Apr 12, 2021 · 3 comments
Closed

File link handling #119

i-oden opened this issue Apr 12, 2021 · 3 comments
Assignees
@alneberg
Labels
cli must have Cannot deliver on target date without this User Story

Comments

@i-oden
Copy link
Member

i-oden commented Apr 12, 2021 •
edited
Loading

How to resolve and not resolve file links within and outside of specified folders. Includes saving link information to database and creating links on download.
@i-oden i-oden self-assigned this Apr 12, 2021
@i-oden i-oden transferred this issue from ScilifelabDataCentre/dds_web Jun 16, 2021
@i-oden i-oden added must have Cannot deliver on target date without this should have Important but not vital and removed must have Cannot deliver on target date without this labels Jul 1, 2021
@i-oden i-oden added the Next Sprint Suggested task (option) for next sprint label Sep 21, 2021
@i-oden i-oden removed their assignment Sep 21, 2021
@i-oden i-oden added User Story and removed Task labels Sep 21, 2021
@i-oden i-oden changed the title Add handling of file links File link handling Sep 21, 2021
@i-oden i-oden added must have Cannot deliver on target date without this and removed should have Important but not vital labels Oct 5, 2021
@i-oden i-oden removed the Next Sprint Suggested task (option) for next sprint label Oct 5, 2021
@alneberg
Copy link
Contributor

alneberg commented Oct 6, 2021

My plan:

  • Link within directory to be uploaded
    • Keep as a link
  • Link outside of the directory to be uploaded
    • Include as a regular file

Pathlib resolve includes a check for infinite loops of links, so that issue (that I started to worry about) should not be so tricky. 👍

@inaod568 what do you think about the plan?

@i-oden
Copy link
Member Author

i-oden commented Oct 6, 2021

My plan:

* Link within directory to be uploaded
  
  * Keep as a link

* Link outside of the directory to be uploaded
  
  * Include as a regular file

Pathlib resolve includes a check for infinite loops of links, so that issue (that I started to worry about) should not be so tricky. 👍

@inaod568 what do you think about the plan?

@alneberg Yes, sounds good! Great news about the infinite loop issue.

@alneberg
Copy link
Contributor

We decided to not save links in the database. A link should be treated as a file. Names of the links should be conserved but the contents of the file the link is pointing to. #175 is related to how links are handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alneberg alneberg

Labels
cli must have Cannot deliver on target date without this User Story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alneberg @i-oden