Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quieter datum warning #6050

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Quieter datum warning #6050

merged 7 commits into from
Jul 17, 2024

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Closes #5749


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers trexfeathers requested a review from HGWright July 15, 2024 16:18
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (17dd34a) to head (5586f3f).
Report is 61 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6050   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          90       90           
  Lines       22991    22991           
  Branches     5031     5031           
=======================================
  Hits        20639    20639           
  Misses       1621     1621           
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers, just a small comment about the whatsnew entry grammar.

docs/src/whatsnew/latest.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that change.

@HGWright HGWright enabled auto-merge (squash) July 17, 2024 14:18
@HGWright HGWright merged commit c66703a into SciTools:main Jul 17, 2024
20 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Jul 18, 2024
* upstream/main:
  Quieter datum warning (SciTools#6050)
  Allow MeshCoord to have a coord-system (SciTools#6016)
  Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053)
  Faster concatenation of cubes with `AuxCoordFactory`s (SciTools#6038)
  Shorten cube iterator tests (SciTools#6041)
  Bump scitools/workflows from 2024.07.0 to 2024.07.1 (SciTools#6045)
  Bump scitools/workflows from 2024.06.5 to 2024.07.0 (SciTools#6034)
  Update test_Saver__ugrid.py (SciTools#6017)
  NEP29 and NumPy v2 pins (SciTools#6039)
  Adapt setup.py for pypa/setuptools@2db55275f. (SciTools#6036)
  Replace DelegatedConda with Delegated (SciTools#5963)
  Enable type hint checking (SciTools#5956)
  Bump scitools/workflows from 2024.06.4 to 2024.06.5 (SciTools#6026)
  Do not realize cell measures and ancillary variables in concatenate (SciTools#6010)
  [pre-commit.ci] pre-commit autoupdate (SciTools#6022)
  Bump scitools/workflows from 2024.06.3 to 2024.06.4 (SciTools#6018)
stephenworsley added a commit to stephenworsley/iris that referenced this pull request Jul 18, 2024
* main:
  Quieter datum warning (SciTools#6050)
  Allow MeshCoord to have a coord-system (SciTools#6016)
  Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve datum FUTURE warning
2 participants