Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt setup.py for pypa/setuptools@2db55275f #6036

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

We were mistakenly passing a tuple into something that needed a list - needs to be a mutable object.

pypa/setuptools@2db55275f


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers trexfeathers requested a review from HGWright July 2, 2024 13:35
@github-actions github-actions bot added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (1a73e84) to head (c86e514).
Report is 56 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6036   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          90       90           
  Lines       22984    22984           
  Branches     5031     5031           
=======================================
  Hits        20634    20634           
  Misses       1619     1619           
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging this while the benchmarks are still in progress, since a full run is not necessary to test the change that we have made. We just wanted to make sure that the benchmarks could run and iris could be installed. (This is something that changing setup.py could affect.) We have confirmed that the benchmarks have completed full runs with this commit checked out and is able to run the benchmarks where as the commit on main is having benchmarks fail, (the change that we are making fixed that).

@HGWright HGWright enabled auto-merge (squash) July 2, 2024 14:02
@trexfeathers trexfeathers disabled auto-merge July 2, 2024 14:24
@trexfeathers trexfeathers merged commit d0801aa into SciTools:main Jul 2, 2024
20 of 21 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Jul 18, 2024
* upstream/main:
  Quieter datum warning (SciTools#6050)
  Allow MeshCoord to have a coord-system (SciTools#6016)
  Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053)
  Faster concatenation of cubes with `AuxCoordFactory`s (SciTools#6038)
  Shorten cube iterator tests (SciTools#6041)
  Bump scitools/workflows from 2024.07.0 to 2024.07.1 (SciTools#6045)
  Bump scitools/workflows from 2024.06.5 to 2024.07.0 (SciTools#6034)
  Update test_Saver__ugrid.py (SciTools#6017)
  NEP29 and NumPy v2 pins (SciTools#6039)
  Adapt setup.py for pypa/setuptools@2db55275f. (SciTools#6036)
  Replace DelegatedConda with Delegated (SciTools#5963)
  Enable type hint checking (SciTools#5956)
  Bump scitools/workflows from 2024.06.4 to 2024.06.5 (SciTools#6026)
  Do not realize cell measures and ancillary variables in concatenate (SciTools#6010)
  [pre-commit.ci] pre-commit autoupdate (SciTools#6022)
  Bump scitools/workflows from 2024.06.3 to 2024.06.4 (SciTools#6018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants